report: include network interfaces in report #28911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
richardlau
approved these changes
Jul 31, 2019
addaleax
approved these changes
Jul 31, 2019
trivikr
approved these changes
Jul 31, 2019
ZYSzys
approved these changes
Aug 1, 2019
Collaborator
jasnell
approved these changes
Aug 1, 2019
Collaborator
Trott
added
the
semver-minor
Trott
approved these changes
Aug 2, 2019
Trott
added
the
author ready
PR-URL: nodejs#28911 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 6, 2019
PR-URL: #28911 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR
added a commit
that referenced
this pull request
Aug 6, 2019
Notable changes:
* assert:
* Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
#28892
* crypto:
* The `outputLength` option is added to `crypto.createHash`
(Tobias Nießen) #28805
* The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
#28799
* n-api:
* Added APIs for per-instance state management (Gabriel Schulhof)
#28682
* report:
* Network interfaces get included in the report (cjihrig)
#28911
* src:
* `v8.getHeapCodeStatistics()` is now exported
(Yuriy Vasiyarov) #27978
PR-URL: #29017
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 6, 2019
Notable changes:
* assert:
* Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
nodejs#28892
* crypto:
* The `outputLength` option is added to `crypto.createHash`
(Tobias Nießen) nodejs#28805
* The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
nodejs#28799
* n-api:
* Added APIs for per-instance state management (Gabriel Schulhof)
nodejs#28682
* report:
* Network interfaces get included in the report (cjihrig)
nodejs#28911
* src:
* `v8.getHeapCodeStatistics()` is now exported
(Yuriy Vasiyarov) nodejs#27978
PR-URL: nodejs#29017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist in debugging networking issues.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes