Skip to content

src: refactor to avoid goto in node_file.cc #32637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tniessen wants to merge 1 commit into from
Closed

src: refactor to avoid goto in node_file.cc #32637

tniessen wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Apr 3, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Apr 3, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30445/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30448/

@tniessen tniessen added the review wanted PRs that need reviews. label Apr 6, 2020
@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Landed in f4dfbeb

addaleax pushed a commit that referenced this pull request Apr 7, 2020
@tniessen @addaleax
src: refactor to avoid goto in node_file.cc
f4dfbeb 
PR-URL: #32637
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax addaleax closed this Apr 7, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
@tniessen @targos
src: refactor to avoid goto in node_file.cc
246b789 
PR-URL: #32637
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@tniessen @BethGriggs
src: refactor to avoid goto in node_file.cc
9ed6d84 
PR-URL: #32637
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@tniessen @targos
src: refactor to avoid goto in node_file.cc
a502209 
PR-URL: #32637
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen @nodejs-github-bot @addaleax @jasnell