worker: use _writev in internal communication #33454
Conversation
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Changes LGTM.
The only concern I have here is whether or not we can somehow pass too much data here by postMessageing all the chunks at once. Also am a bit disappointed we don't have a niftier API for pushing multiple things at once (like Array.prototype.push has).
It’s only going to
Not sure, are you referring to |
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31388/ (:yellow_heart:) |
PR-URL: #33454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in d2a6f06 |
PR-URL: #33454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #33454 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
5 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes