Skip to content

quic misc fix #33975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 2 commits into from
Closed

quic misc fix #33975

gengjiawen wants to merge 2 commits into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jun 19, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jun 19, 2020
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 19, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31966/

👍 this comment to approve fast-tracking

@jasnell jasnell added the experimental Issues and PRs related to experimental features. label Jun 19, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32004/

gengjiawen added a commit that referenced this pull request Jun 22, 2020
@gengjiawen
quic: fix typo in comments
9743624 
PR-URL: #33975
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
gengjiawen added a commit that referenced this pull request Jun 22, 2020
@gengjiawen
quic: fix clang-tidy performance-faster-string-find issue
09330fc 
PR-URL: #33975
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gengjiawen
Copy link
Member Author

gengjiawen commented Jun 22, 2020

Landed in b8ea471...09330fc

@gengjiawen gengjiawen closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

+3 more reviewers

@devnexen devnexen devnexen approved these changes

@devsnek devsnek devsnek approved these changes

@MrHeer MrHeer MrHeer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gengjiawen @nodejs-github-bot @jasnell @addaleax @devnexen @richardlau @devsnek @trivikr @MrHeer @codebytere