src: refactor code to remove duplicate logic

[yashLadha]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[mscdex]

What do you mean by "library name" ?

[yashLadha]

@mscdex array is part of default library provided by C++ http://www.cplusplus.com/reference/array/array/. When I first read the lines I thought why are we saving it in the default library keyword. This is done on the lines we won't name a variablevector.

[addaleax]

I don’t see any particular reason to avoid the names of standard library classes. We’re never importing items from the std namespace with using, so there’s no chance for conflicts, either.

[yashLadha]

@addaleax Agree with you but as a convention should we be using keyword names as an identifier? I wrote the patch because if someone reads it they might think why we are using this variable name when it is a keyword defined in one the libraries provided. As we avoid using list as an identifier and give it a meaningful name this is done on the same lines. I don't see any issues with that but open to thoughts around this 😄

[joyeecheung]

I'd prefer readability over potential keyword conflicts as well - especially considering the std namespace can be extended as C++ grows and keywords like list queue map set are already there. If anything, renaming array to something even more descriptive would be nice, like fields_array or typed_array here (I don't know how to name it in a way that's succinct enough while saying "this is a float64 array whose values will be read from the JS land later" to be honest so take my suggestion with a grain of salt)

[yashLadha]

@joyeecheung Agree with you but my intention behind the changes is similar to usage of ab for arrayBuffer however your suggestion seems valid and the naming should be much more verbose in its meaning. Any suggestion or best practice for native code which we follow in the nodejs community?

[joyeecheung]

@yashLadha I don't think there's any particular convention in native code variable naming, it's just my personal opinion that verbose names are better than names like ab (as one would have to see them a few times in the code base before understanding what they stand for, which makes it more difficult for new-comers to get started with the code base)

[yashLadha]

@joyeecheung @addaleax when I looked in the complete file itself found that this logic is being duplicated at several places, so converted the logic to use a single inline function so that code doesn't get duplicated.

[yashLadha]

Also no performance degradation as well

                                 confidence improvement accuracy (*)   (**)  (***)
 process/memoryUsage.js n=100000        ***      4.51 %       ±0.90% ±1.19% ±1.52%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

[addaleax]

Are the unrelated formatting changes here done by clang-format?

[yashLadha]

Yes @addaleax linter did that.

[joyeecheung]

It would be better to name it like get_fields_array_buffer_from_first_argument, or accept an argument specifying the index of the argument array, otherwise this new convention makes the code less easier to grok IMO.

[tniessen]

Lots of unrelated whitespace changes.

[tniessen]

Do we want these kind of changes?

[yashLadha]

This was done by the clang-formatter 😅 not intentional

[joyeecheung]

Can you try reformatting the code and make sure you set CLANG_FORMAT_START to where this branch branches off from the master, so that it does not format irrelevant changes? For example since this PR only contains 3 commits you can also try CLANG_FORMAT_START=HEAD~3 make format-cpp

[yashLadha]

@joyeecheung Output from the command

❯ CLANG_FORMAT_START=HEAD~3 make format-cpp
Formatting C++ diff from HEAD~3..
clang-format did not modify any files

I think what i can do is basically reset to master and do the changes only and do not format the code. In that way those unnecessary changes won't be there.

[yashLadha]

Removed the formatting changes.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/34277/

[github-actions]

Landed in 4b0308a...8656ab4