Skip to content

Conversation

@NickNaso
Copy link
Member

Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix.
This change should fix the problem in the documentation.

Checklist

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/n-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Sep 23, 2020
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Node.js version 14.12.0 released the N-API version 7, but it's not
present on the N-API version matrix. This change  should fix the problem
in the documentation.

PR-URL: #35319
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit d7dfa66 into nodejs:master Sep 26, 2020
@Trott
Copy link
Member

Trott commented Sep 26, 2020

Landed in d7dfa66

MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
Node.js version 14.12.0 released the N-API version 7, but it's not
present on the N-API version matrix. This change  should fix the problem
in the documentation.

PR-URL: #35319
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
@mhdawson mhdawson mentioned this pull request Sep 30, 2020
3 tasks
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Node.js version 14.12.0 released the N-API version 7, but it's not
present on the N-API version matrix. This change  should fix the problem
in the documentation.

PR-URL: nodejs#35319
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants