doc: improve N-API string-to-native doc #35322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention null termination handling in the string size accounting and string truncation.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
NickNaso
approved these changes
Sep 23, 2020
addaleax
approved these changes
Sep 24, 2020
Member
|
Doc only so linters run on PR are enough, landing |
mhdawson
pushed a commit
that referenced
this pull request
Sep 25, 2020
Mention null termination handling in the string size accounting and string truncation. PR-URL: #35322 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
|
Landed in b54dd8d |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2020
Mention null termination handling in the string size accounting and string truncation. PR-URL: #35322 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Mention null termination handling in the string size accounting and string truncation. PR-URL: nodejs#35322 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention null termination handling in the string size accounting and
string truncation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes