Skip to content

[v12.x backport] fs: add .ref() and .unref() methods to watcher classes #35555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpinca wants to merge 1 commit into from
Closed

[v12.x backport] fs: add .ref() and .unref() methods to watcher classes #35555

lpinca wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Oct 8, 2020 •
edited
Loading

PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell [email protected]
Reviewed-By: Anna Henningsen [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@rickyes @lpinca
fs: add .ref() and .unref() methods to watcher classes
ce9022d 
PR-URL: nodejs#33134
Fixes: nodejs#33096
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Oct 8, 2020
@lpinca
Copy link
Member Author

lpinca commented Oct 8, 2020

cc: @rickyes

@lpinca lpinca changed the title fs: add .ref() and .unref() methods to watcher classes [v12.x backport] fs: add .ref() and .unref() methods to watcher classes Oct 8, 2020
rickyes
rickyes approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 8, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33474/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33489/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33510/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33563/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33567/ ✅

@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 15, 2020
@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@rickyes @MylesBorins
fs: add .ref() and .unref() methods to watcher classes
3e297cf 
Backport-PR-URL: #35555
PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 3, 2020

landed in 3e297cf

@MylesBorins MylesBorins closed this Nov 3, 2020
@lpinca lpinca deleted the backport-33134-to-v12.x branch November 3, 2020 17:43
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@rickyes @MylesBorins
fs: add .ref() and .unref() methods to watcher classes
decfc2a 
Backport-PR-URL: #35555
PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

+1 more reviewer

@rickyes rickyes rickyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca @nodejs-github-bot @MylesBorins @fhinkel @rickyes