Skip to content

benchmark: ignore build artifacts for napi addons #35970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richardlau wants to merge 1 commit into from
Closed

benchmark: ignore build artifacts for napi addons #35970

richardlau wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Nov 4, 2020

Add .gitignore to ignore the build directory in a similar way
to the other addons under benchmark/napi.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 4, 2020
@richardlau
Copy link
Member Author

richardlau commented Nov 4, 2020

Adding watch labels for the release lines that #28237 has landed.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
benchmark: ignore build artifacts for napi addons
8a22f7d 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34076/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34082/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34092/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34093/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34096/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34097/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2020 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34101/ (✅)

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 5, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

Landed in 3c9f072...85b42af

@github-actions github-actions bot closed this Nov 7, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 7, 2020
@richardlau @nodejs-github-bot
benchmark: ignore build artifacts for napi addons
85b42af 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau richardlau deleted the ignore branch November 7, 2020 03:00
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@richardlau @danielleadams
benchmark: ignore build artifacts for napi addons
9d9a044 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@richardlau @MylesBorins
benchmark: ignore build artifacts for napi addons
f7ee9f2 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@richardlau @MylesBorins
benchmark: ignore build artifacts for napi addons
c6eb0b6 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 16, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@richardlau @BethGriggs
benchmark: ignore build artifacts for napi addons
aa18ac0 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@richardlau @BethGriggs
benchmark: ignore build artifacts for napi addons
930bc5d 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@richardlau @BethGriggs
benchmark: ignore build artifacts for napi addons
d027be0 
Add `.gitignore` to ignore the `build` directory in a similar way
to the other addons under `benchmark/napi`.

PR-URL: #35970
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau @nodejs-github-bot @Trott @addaleax @lpinca @MylesBorins @BethGriggs