doc: document that module.evaluate fulfills as undefined #37663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#37453 Signed-off-by: James M Snell <[email protected]>
nodejs-github-bot
added
doc
devsnek
approved these changes
Mar 9, 2021
marsonya
approved these changes
Mar 9, 2021
RaisinTen
approved these changes
Mar 9, 2021
Member
Author
|
fast-track? please 👍🏻 |
Member
Author
|
Landed in 16151be |
jasnell
added a commit
that referenced
this pull request
Mar 9, 2021
Fixes: #37453 Signed-off-by: James M Snell <[email protected]> PR-URL: #37663 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Fixes: #37453 Signed-off-by: James M Snell <[email protected]> PR-URL: #37663 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fixes: #37453 Signed-off-by: James M Snell <[email protected]> PR-URL: #37663 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37453
Signed-off-by: James M Snell [email protected]