Skip to content

[v16.x] deps: V8: Add Power10 to the supported list and enable related features #38489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miladfarca wants to merge 2 commits into from
Closed

[v16.x] deps: V8: Add Power10 to the supported list and enable related features #38489

miladfarca wants to merge 2 commits into from

Conversation

@miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Apr 30, 2021 •
edited
Loading

Please note that enum values are slightly different from V8 upstream, i.e PPC_POWER10 instead of kPPCPower10.
We also have SIMD enabled upstream which will not be backported here.

Refs: v8/v8@530080c

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Apr 30, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37849/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37854/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37860/

@miladfarca
Copy link
Contributor Author

miladfarca commented May 1, 2021

@richardlau is test-crypto-timing-safe-equal-benchmarks flaky on s390? as my changes are ppc specific.

@richardlau
Copy link
Member

richardlau commented May 1, 2021

@miladfarca The test has been failing a lot recently on s390x: #38226
It’s not clear as to what has changed to make the test fail and whether or not there is an underlying defect.

@miladfarca
Copy link
Contributor Author

miladfarca commented May 1, 2021 •
edited
Loading

Thanks for the link. Yes some other tests seem to be flaky too i.e inspector-cli/test-inspector-cli-address failed on AIX and inspector-cli/test-inspector-cli-pid on ppc on the previous runs.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37864/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37888/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 3, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37889/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3972/

@miladfarca miladfarca mentioned this pull request May 3, 2021
Merged
@aduh95
Copy link
Contributor

aduh95 commented May 3, 2021

Should this target master instead of v16.x-staging?

@miladfarca
Copy link
Contributor Author

miladfarca commented May 3, 2021

@aduh95 There is already a PR open to update V8 on master, I've request a cherry pick: #38273

@jasnell jasnell changed the title deps: V8: Add Power10 to the supported list and enable related features [v16.x] deps: V8: Add Power10 to the supported list and enable related features May 4, 2021
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label May 4, 2021
mhdawson
mhdawson approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38084/

@miladfarca
Copy link
Contributor Author

miladfarca commented May 14, 2021

@richardlau Would you please help with landing this as well?
Also is there a way to only re-run the AIX test? Failure shouldn't be related to this PR.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38090/

richardlau pushed a commit that referenced this pull request May 14, 2021
@richardlau
deps: V8: cherry-pick 530080c44af2
f31a611 
    Original commit message:
    ```
    PPC: Add Power10 to the supported list and enable related features

    This CL adds Power10 recognition to Linux, AIX as well as IBMi.

    Enabled features include:
    MODULO
    FPR_GPR_MOV
    SIMD
    LWSYNC
    ISELECT
    VSX

    Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
    Reviewed-by: Clemens Backes <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Reviewed-by: Vasili Skurydzin <[email protected]>
    Commit-Queue: Milad Fa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#74279}
    ```

Refs: v8/v8@530080c

PR-URL: #38489
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

richardlau commented May 14, 2021

Landed in f31a611.

@richardlau richardlau closed this May 14, 2021
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@AshCripps AshCripps AshCripps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.