crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label #38926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codebytere
force-pushed
the
fix-EVP_PKEY_CTX_set0_rsa_oaep_label-cast
branch
from
f6e68b1 to
d0e22e7
Compare
bl-ue
approved these changes
Jun 4, 2021
Trott
approved these changes
Jun 4, 2021
addaleax
approved these changes
Jun 5, 2021
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but we always use static_cast when possible – feel free to update the other use of this as well
codebytere
force-pushed
the
fix-EVP_PKEY_CTX_set0_rsa_oaep_label-cast
branch
from
d0e22e7 to
474fa4f
Compare
Collaborator
tniessen
approved these changes
Jun 6, 2021
codebytere
added a commit
that referenced
this pull request
Jun 6, 2021
PR-URL: #38926 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Member
Author
|
Landed in d07c12f |
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38926 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
5 tasks
Member
|
Doesn't land cleanly on v14.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects cast for
labelas passed toEVP_PKEY_CTX_set0_rsa_oaep_labelThis has already been done here and causes BoringSSL failures if not cast from
void*.