Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Sep 15, 2022

Following up on #44627 (comment), adding benchmark written by @mscdex

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 15, 2022
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider adding in the commit message:

Co-authored-by: Brian White <[email protected]>

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Co-authored-by: Brian White <[email protected]>
PR-URL: nodejs#44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@anonrig anonrig merged commit 267a03e into nodejs:main Oct 14, 2022
@anonrig anonrig deleted the benchmark/events branch October 14, 2022 15:44
@anonrig
Copy link
Member Author

anonrig commented Oct 14, 2022

Landed in 267a03e

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Co-authored-by: Brian White <[email protected]>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: Brian White <[email protected]>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Co-authored-by: Brian White <[email protected]>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Co-authored-by: Brian White <[email protected]>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Co-authored-by: Brian White <[email protected]>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants