Skip to content

Conversation

@KevinEady
Copy link
Contributor

Add a link to the Node-API Media page in the Node-API docs.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jan 12, 2023
@KevinEady KevinEady marked this pull request as draft January 12, 2023 20:31
@KevinEady KevinEady force-pushed the add-node-api-media-doc-link branch from e556fbb to 33edd20 Compare January 12, 2023 20:31
@KevinEady KevinEady marked this pull request as ready for review January 12, 2023 20:42
@KevinEady KevinEady force-pushed the add-node-api-media-doc-link branch from 33edd20 to 1243b97 Compare January 12, 2023 21:02
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit 09aed32 into nodejs:main Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 09aed32

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46189
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46189
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46189
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46189
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants