Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 26, 2023

Enforce trailing commas in more places, and add them where they were missing in the benchmark files.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. diagnostics_channel Issues and PRs related to diagnostics channel dns Issues and PRs related to the dns subsystem. domain Issues and PRs related to the domain subsystem. http Issues or PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Jan 26, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed http Issues or PRs related to the http subsystem. assert Issues and PRs related to the assert subsystem. cluster Issues and PRs related to the cluster subsystem. child_process Issues and PRs related to the child_process subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. dns Issues and PRs related to the dns subsystem. domain Issues and PRs related to the domain subsystem. v8 engine Issues and PRs related to the V8 dependency. diagnostics_channel Issues and PRs related to diagnostics channel labels Jan 26, 2023
@aduh95 aduh95 merged commit ca5f322 into nodejs:main Jan 29, 2023
@aduh95 aduh95 deleted the benchmark-dangle branch January 29, 2023 18:13
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 29, 2023

Landed in ca5f322

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
PR-URL: #46370
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants