Skip to content

tools: limit parallelism with ninja in V8 builds #51473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 17, 2024
Merged

tools: limit parallelism with ninja in V8 builds #51473

nodejs-github-bot merged 1 commit into from
Jan 17, 2024
+7 −2

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Jan 15, 2024 •
edited
Loading

If JOBS has been set in the environment to limit build parallelism, pass that onto ninja when building V8.

Refs: #51362 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jan 15, 2024
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 15, 2024
@richardlau

This comment was marked as outdated.

Sign in to view
@richardlau
tools: limit parallelism with ninja in V8 builds
c6ebd02 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56793/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5772/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5772/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5772/

@richardlau richardlau mentioned this pull request Jan 15, 2024
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56801/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/56802/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 16, 2024
mhdawson
mhdawson approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6ce718d into nodejs:main Jan 17, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2024

Landed in 6ce718d

@richardlau richardlau deleted the parallel-ninja branch January 17, 2024 17:57
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@richardlau @Medhansh404
tools: limit parallelism with ninja in V8 builds
699ff90 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: nodejs#51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 22, 2024
@richardlau @marco-ippolito
tools: limit parallelism with ninja in V8 builds
2182d66 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: nodejs#51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
@richardlau @marco-ippolito
tools: limit parallelism with ninja in V8 builds
ea5553f 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: nodejs#51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@richardlau @targos
tools: limit parallelism with ninja in V8 builds
81fd7d1 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: #51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@richardlau @marco-ippolito
tools: limit parallelism with ninja in V8 builds
043e25c 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: nodejs#51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: limit parallelism with ninja in V8 builds
6b54e35 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: #51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
tools: limit parallelism with ninja in V8 builds
e8dc5ac 
If `JOBS` has been set in the environment to limit build parallelism,
pass that onto `ninja` when building V8.

PR-URL: #51473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@richardlau @nodejs-github-bot @lpinca @anonrig @targos @mhdawson @aymen94 @aduh95