-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: change ExperimentalWarnings to ExperimentalWarning
#51741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
you need to edit your first commit message you can do it like this : |
Sure, @mertcanaltin. Working on modifying the commit message and rebasing my PR now. Will post here when done. |
ExperimentalWarnings to ExperimentalWarningExperimentalWarnings to ExperimentalWarning
@mertcanaltin - Just rebased and force pushed the commit with the modified commit message. PS. Notes for myself
|
|
Landed in 123dc51 |
PR-URL: #51741 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#51741 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Change Summary
This PR changes
ExperimentalWarningstoExperimentalWarningin the documentation for the latest version of NodeJS as of this writing -v21.6.1.Why?
I am using the experimental JSON Modules feature within my NodeJS project. Although the JSON Modules feature works, whenever I execute my ES Module based JavaScript file, I would receive the following warning:
After reading through the documentation under the section titled
--disable-warning=code-or-type, I tried to suppress theExperimentalWarningby changing the followingstartscript within mypackage.jsonfile:{ ... "scripts": { "start": "node --disable-warning=ExperimentalWarnings src/index.js" }, ... }But I still received the aforementioned
ExperimentalWarningwithin my console.After re-reading the documentation (and referring other documentations - like this comment on issue #30810), instead of the plural version (
ExperimentalWarnings), I tried the singular version (ExperimentalWarning):{ ... "scripts": { - "start": "node --disable-warning=ExperimentalWarnings src/index.js" + "start": "node --disable-warning=ExperimentalWarning src/index.js" }, ... }And it worked! The warning was suppressed.
Hence, this PR to address the confusion in the documentation.