test: make sure current run result is pushed and reset #54332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
jakecastelli
force-pushed
the
fix-result-push-and-reset
branch
from
59e3f97 to
60b8da8
Compare
jakecastelli
force-pushed
the
fix-result-push-and-reset
branch
from
60b8da8 to
73acd48
Compare
jakecastelli
commented
Aug 12, 2024
| if (common.isIBMi) | ||
| common.skip('IBMi does not support `fs.watch()`'); | ||
|
|
||
| if (common.isAIX) |
Member
Author
There was a problem hiding this comment.
I had a rough time with CI on AIX previously, I don't know if we should skip it entirely or just skip the test that has 100% failure rate due to the platform limitation (in this case the file deletion test)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54332 +/- ##
==========================================
- Coverage 87.09% 87.08% -0.02%
==========================================
Files 647 647
Lines 181889 181930 +41
Branches 34884 34899 +15
==========================================
+ Hits 158420 158433 +13
- Misses 16773 16779 +6
- Partials 6696 6718 +22 |
github-actions
bot
removed
the
request-ci
Collaborator
jakecastelli
added
the
author ready
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c1ec099 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54332 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
currentRunresult is only pushed intorunsafter the second test run finished, therefore all therunsarray's length is1(with 2 runs results concat into 1 big string). Added assertion to make surerunshave the correct length (number of runs).