Skip to content

test: add Float16Array to common.getArrayBufferViews() #58233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 10, 2025
Merged

test: add Float16Array to common.getArrayBufferViews() #58233

nodejs-github-bot merged 1 commit into from
May 10, 2025

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented May 8, 2025

No description provided.

@LiviaMedeiros LiviaMedeiros added test Issues and PRs related to the tests. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x labels May 8, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66709/

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (535c2f7) to head (3738447).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58233      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.02%     
==========================================
  Files         629      629              
  Lines      186638   186638              
  Branches    36618    36620       +2     
==========================================
+ Hits       168202   168244      +42     
+ Misses      11222    11208      -14     
+ Partials     7214     7186      -28

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66733/

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit f8809ce into nodejs:main May 10, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 10, 2025

Landed in f8809ce

targos pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros @targos
test: add Float16Array to common.getArrayBufferViews()
97f8037 
PR-URL: #58233
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LiviaMedeiros @nodejs-github-bot @lpinca @targos @cjihrig @atlowChemi