Test: Updated test/parallel/test-fs-write-file.js. #9992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated references of var to const - Updated assert.equal to assert.strictEqual - Fixed eslint error for multiline string on line 12.
imyller
added
the
code-and-learn
Contributor
|
Subsystem name should be all lowercase. Also, a minor nit: the trailing period at the end of the first line of the commit message is unnecessary. |
Member
Trott
requested changes
Dec 4, 2016
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Actually, I take it back. The change to the multi-line string on line 12 would seem to change the string by introducing a lot more whitespace, unless I'm missing something... It is also contrary to the conventions throughout the rest of the code base.
Trott
approved these changes
Dec 4, 2016
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
CI is green. I'll undo the whitespace/string thing on landing. LGTM. Landing!
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
- Updated references of var to const - Updated assert.equal to assert.strictEqual PR-URL: nodejs#9992 Reviewed-By: Rich Trott <[email protected]>
Member
|
Landed in 451f88e. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
- Updated references of var to const - Updated assert.equal to assert.strictEqual PR-URL: #9992 Reviewed-By: Rich Trott <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- Updated references of var to const - Updated assert.equal to assert.strictEqual PR-URL: nodejs#9992 Reviewed-By: Rich Trott <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
- Updated references of var to const - Updated assert.equal to assert.strictEqual PR-URL: nodejs#9992 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- Updated references of var to const - Updated assert.equal to assert.strictEqual PR-URL: #9992 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change