Prefactor: Build changes for #1475 #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of future changes to introduce the `net/http`-only server, we'll introduce the reliance on Go 1.22-only code. The way that we currently lint/build/etc the project doesn't make this easy to do so, so we should instead refactor our build steps to make this easier. This is the best option I can see right now, but will be happy to tweak it if we can find an alternative.
I'd not realised that we were - still - using this separate setup just in GitHub Actions. To make this cleaner, as well as fit into our new structure for managing multi-module `Makefile`s, we can create a new `make` task for CI.
jamietanna
added
the
chore
Both to fix issues with Go 1.21's detection of `go env GOVERSION`, as well as generally making it extra explicit that we don't want to auto-upgrade.
jamietanna
force-pushed
the
chore/prefactor
branch
from
f78321d to
c19b849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maketargetmake linttomake helpMakefileper moduletidy-cimake targetGOTOOLCHAIN