-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(core): load custom prompts from symlinked Markdown files #3643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): load custom prompts from symlinked Markdown files #3643
Conversation
- Discover prompts via fs::metadata to follow symlinks - Add Unix-only symlink test in custom_prompts.rs - Update docs/prompts.md to mention symlinks Fixes openai#3637 Signed-off-by: Soroush Yousefpour <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@codex pls format and fix clippy warnings if any |
|
Note For now, I can only help with PRs you've created. |
|
@gabrimatic Salam! Can you please run |
|
@codex pls format and fix clippy warnings if any |
|
Note To use Codex here, create an environment for this repo. |
|
Thanks for your contribution, and apologies for taking so long to review. We received a lot of PRs, and we're just now getting to the backlog. If you're still interested in pursuing this PR, could you please resolve the merge conflicts? |
|
@etraut-openai Sure, I just fixed the conflicts. |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Discover prompts via fs::metadata to follow symlinks
Add Unix-only symlink test in custom_prompts.rs
Update docs/prompts.md to mention symlinks
Fixes #3637