[App-server] Implement v2 for account/login/start and account/login/completed
#6183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
force-pushed
the
dev/cc/account-2
branch
2 times, most recently
from
65ff9e0 to
1568f63
Compare
celia-oai
force-pushed
the
dev/cc/account-2
branch
2 times, most recently
from
59d74c7 to
4943d31
Compare
celia-oai
changed the title
account/login/start account/login/completed and account/login/cancel account/login/start account/login/completed and account/login/cancel
celia-oai
force-pushed
the
dev/cc/account-2
branch
4 times, most recently
from
c89e13b to
ad00c91
Compare
celia-oai
force-pushed
the
dev/cc/account-2
branch
5 times, most recently
from
a48058e to
6a82787
Compare
celia-oai
changed the title
account/login/start account/login/completed and account/login/cancel account/login/start and account/login/completed
celia-oai
force-pushed
the
dev/cc/account-2
branch
5 times, most recently
from
f5e57aa to
276537c
Compare
celia-oai
changed the title
account/login/start and account/login/completedaccount/login/start and account/login/completed
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
approved these changes
Nov 5, 2025
celia-oai
force-pushed
the
dev/cc/account-2
branch
from
cadbe08 to
21d7ad3
Compare
celia-oai
force-pushed
the
dev/cc/account-2
branch
4 times, most recently
from
c23094a to
8c06029
Compare
celia-oai
force-pushed
the
dev/cc/account-2
branch
from
8c06029 to
e90f69f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
account/login/startandaccount/login/completed. Instead of having separate endpoints for login with chatgpt and api, we have a single enum handling different login methods. For sync auth methods like sign in with api key, we still send acompletednotification back to be compatible with the async login flow.