Skip to content

Conversation

@danfhernandez
Copy link
Contributor

Summary

  • Adds ModelReasoningEffort type to TypeScript SDK with values: minimal, low, medium, high
  • Adds modelReasoningEffort option to ThreadOptions
  • Forwards the option to the codex CLI via --config model_reasoning_effort="<value>"
  • Includes test coverage for the new option

Changes

  • sdk/typescript/src/threadOptions.ts: Define ModelReasoningEffort type and add to ThreadOptions
  • sdk/typescript/src/index.ts: Export ModelReasoningEffort type
  • sdk/typescript/src/exec.ts: Forward modelReasoningEffort to CLI as config flag
  • sdk/typescript/src/thread.ts: Pass option through to exec (+ debug logging)
  • sdk/typescript/tests/run.test.ts: Add test for modelReasoningEffort flag forwarding

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@danfhernandez
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 5, 2025
- Add ModelReasoningEffort type with minimal/low/medium/high values
- Add modelReasoningEffort to ThreadOptions and pass through exec
- Forward as --config flag to codex CLI
- Add test coverage for modelReasoningEffort option
@danfhernandez danfhernandez force-pushed the typescript-sdk-reasoning-effort branch from 9401556 to ddeec2b Compare November 5, 2025 01:30
@etraut-openai
Copy link
Collaborator

Thanks for the contribution.

We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. With the SDK, in particular, we are being very deliberate about what features we expose and what shape the API takes.

If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
@openai openai unlocked this conversation Nov 5, 2025
@etraut-openai etraut-openai reopened this Nov 5, 2025
@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai merged commit 9a10e80 into openai:main Nov 5, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants