-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add modelReasoningEffort option to TypeScript SDK #6237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modelReasoningEffort option to TypeScript SDK #6237
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
- Add ModelReasoningEffort type with minimal/low/medium/high values - Add modelReasoningEffort to ThreadOptions and pass through exec - Forward as --config flag to codex CLI - Add test coverage for modelReasoningEffort option
9401556 to
ddeec2b
Compare
|
Thanks for the contribution. We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. With the SDK, in particular, we are being very deliberate about what features we expose and what shape the API takes. If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ModelReasoningEfforttype to TypeScript SDK with values:minimal,low,medium,highmodelReasoningEffortoption toThreadOptions--config model_reasoning_effort="<value>"Changes
sdk/typescript/src/threadOptions.ts: DefineModelReasoningEfforttype and add toThreadOptionssdk/typescript/src/index.ts: ExportModelReasoningEfforttypesdk/typescript/src/exec.ts: ForwardmodelReasoningEffortto CLI as config flagsdk/typescript/src/thread.ts: Pass option through to exec (+ debug logging)sdk/typescript/tests/run.test.ts: Add test formodelReasoningEffortflag forwarding