fix: update brew auto update version check #6238

shijie-oai · 2025-11-05T01:44:04Z

Summary

Use https://github.com/Homebrew/homebrew-cask/blob/main/Casks/c/codex.rb to get the latest available version for brew usage.

codex-rs/tui/src/updates.rs

shijie-oai · 2025-11-07T23:35:25Z

codex-rs/tui/src/updates.rs

    BrewUpgrade,
 }

-#[cfg(any(not(debug_assertions), test))]


All the usage of this is guarded - without removing this I have string #[cfg(any(not(debug_assertions), test))] through get_upgrade_version which triggers a lot more changes. Alternatively I can create another get_update_action which returns None for debug_assertions cfg only but that is not super clean.

This is here so that we don't get the message all the time in dev mode. I think it's important to make this work.

shijie-oai · 2025-11-07T23:35:39Z

codex-rs/tui/src/updates.rs

        match self {
            UpdateAction::NpmGlobalLatest => ("npm", &["install", "-g", "@openai/codex@latest"]),
            UpdateAction::BunGlobalLatest => ("bun", &["install", "-g", "@openai/codex@latest"]),
-            UpdateAction::BrewUpgrade => ("brew", &["upgrade", "--cask", "codex"]),


Remove --cask flag because it is not necessary.

shijie-oai · 2025-11-07T23:40:16Z

codex-rs/tui/src/updates.rs


 use crate::version::CODEX_CLI_VERSION;

 pub fn get_upgrade_version(config: &Config) -> Option<String> {


Both the history cell (displaying upgrade message) and update_prompt (auto update) use this value for showing and calculating the correct update message.

shijie-oai · 2025-11-07T23:58:35Z

codex-rs/tui/src/updates.rs

+    #[serde(default)]
+    latest_brew_version: String,


Optional because the existing version.json does not contain this and parsing it would error (hidden but still).

shijie-oai · 2025-11-08T00:03:23Z

codex-rs/tui/src/updates.rs

-        } else {
-            None
-        }
+        latest_version_for_action(&info, update_action).and_then(|latest_version| {


Get the latest version based on installation method.

shijie-oai · 2025-11-08T00:05:00Z

codex-rs/tui/src/updates.rs

+        Some(UpdateAction::BrewUpgrade) if !info.latest_brew_version.is_empty() => {
+            Some(&info.latest_brew_version)
+        }
+        Some(UpdateAction::BrewUpgrade) => None,


The case which you have a version.json but it is not updated (i.e. not outside the window for updating) and therefore brew version is missing. Instead of using the latest version number from github we will wait until we can get the value from brew.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/updates.rs

shijie-oai · 2025-11-08T00:58:20Z

@codex review it

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-08T01:01:24Z

codex-rs/tui/src/updates.rs

        match self {
            UpdateAction::NpmGlobalLatest => ("npm", &["install", "-g", "@openai/codex@latest"]),
            UpdateAction::BunGlobalLatest => ("bun", &["install", "-g", "@openai/codex@latest"]),
-            UpdateAction::BrewUpgrade => ("brew", &["upgrade", "--cask", "codex"]),
+            UpdateAction::BrewUpgrade => ("brew", &["upgrade", "codex"]),
        }


Restore --cask flag for Brew upgrades

The update action now invokes brew upgrade codex, but Codex is published as a Homebrew cask, not a formula. Our own FAQ (docs/faq.md lines 46‑55) explicitly tells users to run brew upgrade --cask codex after the migration from a formula, because omitting --cask causes Homebrew to look for a formula named codex and fail with “No available formula with the name ‘codex’”. With this change the automatic update the CLI runs (and the command string shown to the user) will always fail for Brew installs, preventing updates for that channel. The UpdateAction::BrewUpgrade branch should continue to pass the --cask flag.

Useful? React with 👍 / 👎.

Upgrade is actually fine and --cask is not necessary.

bolinfest · 2025-11-08T15:27:03Z

codex-rs/tui/src/lib.rs

 mod text_formatting;
 mod tui;
 mod ui_consts;
+pub mod update_action;


Does this need to be pub?

Yes - this is used in the the cli crate for typing https://github.com/openai/codex/blob/main/codex-rs/cli/src/main.rs#L23.

bolinfest · 2025-11-08T15:28:27Z

codex-rs/tui/src/update_action.rs

+    /// Returns string representation of the command-line arguments for invoking the update.
+    pub fn command_str(self) -> String {
+        let (command, args) = self.command_args();
+        let args_str = args.join(" ");


Use shlex.join

bolinfest · 2025-11-08T15:29:49Z

codex-rs/tui/src/update_action.rs

+        let prev = std::env::var_os("CODEX_MANAGED_BY_NPM");
+
+        // First: no npm var -> expect None (we do not run from brew in CI)
+        unsafe { std::env::remove_var("CODEX_MANAGED_BY_NPM") };


You need to test using dependency injection/pass from above for the env: setvar can cause undefined behavior, which is why it is marked unsafe.

codex-rs/tui/src/updates.rs

shijie-oai · 2025-11-09T03:55:03Z

codex-rs/tui/src/update_action.rs

+    detect_update_action(
+        cfg!(target_os = "macos"),
+        &exe,
+        managed_by_npm,
+        managed_by_bun,
+    )


@bolinfest let me know your thoughts on this - it is pretty scalable and we can moved away from setting env variables in tests.

Thanks, yes, this is what I meant by "pass from above."

bolinfest · 2025-11-10T00:16:44Z

codex-rs/tui/src/update_action.rs

+    detect_update_action(
+        cfg!(target_os = "macos"),
+        &exe,
+        managed_by_npm,
+        managed_by_bun,
+    )


Thanks, yes, this is what I meant by "pass from above."

bolinfest · 2025-11-10T00:17:48Z

codex-rs/tui/src/update_action.rs

+    /// Returns the list of command-line arguments for invoking the update.
+    pub fn command_args(self) -> (&'static str, &'static [&'static str]) {
+        match self {
+            UpdateAction::NpmGlobalLatest => ("npm", &["install", "-g", "@openai/codex@latest"]),


I would drop the @latest for now. At least, I wasn't aware that maintaining that tag was part of our contract with the user.

Dropped latest tag for bun install too.

bolinfest · 2025-11-10T00:19:22Z

codex-rs/tui/src/update_action.rs

+    /// Returns string representation of the command-line arguments for invoking the update.
+    pub fn command_str(self) -> String {
+        let (command, args) = self.command_args();
+        shlex::try_join(std::iter::once(command).chain(args.iter().copied()))


That copied() seems a bit suspicious to me. try_join() takes by reference: https://docs.rs/shlex/latest/shlex/fn.try_join.html

Aha this statement has a bit too much of a nesting - .copied() is applied on the args.iter() and not the overall iter object. .chain expects an iterator and not an itr which is why we need to use copied.

bolinfest · 2025-11-10T00:20:32Z

codex-rs/tui/src/update_action.rs

+    if managed_by_npm {
+        return Some(UpdateAction::NpmGlobalLatest);
+    }
+    if managed_by_bun {
+        return Some(UpdateAction::BunGlobalLatest);
+    }
+    if is_macos
+        && (current_exe.starts_with("/opt/homebrew") || current_exe.starts_with("/usr/local"))
+    {
+        return Some(UpdateAction::BrewUpgrade);
+    }
+    None


Unnecessary use of return is not canonical Rust. Prefer:

Suggested change

if managed_by_npm {

return Some(UpdateAction::NpmGlobalLatest);

}

if managed_by_bun {

return Some(UpdateAction::BunGlobalLatest);

}

if is_macos

&& (current_exe.starts_with("/opt/homebrew") || current_exe.starts_with("/usr/local"))

{

return Some(UpdateAction::BrewUpgrade);

}

None

if managed_by_npm {

Some(UpdateAction::NpmGlobalLatest);

} else if managed_by_bun {

Some(UpdateAction::BunGlobalLatest);

} else if is_macos

&& (current_exe.starts_with("/opt/homebrew") || current_exe.starts_with("/usr/local"))

{

Some(UpdateAction::BrewUpgrade);

} else {

None

}

bolinfest · 2025-11-10T00:24:04Z

codex-rs/tui/src/update_action.rs

+    }
+}
+
+#[cfg(any(not(debug_assertions), test))]


This isn't pub, so I don't think you need this cfg line, do you?

I think we should keep it - removing it leads to a dead_code warning for dev build. We can add #[allow(dead_code)] but a strongly defined cfg makes it feel more intentional.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-10T00:28:12Z

codex-rs/tui/src/update_action.rs

+impl UpdateAction {
+    /// Returns the list of command-line arguments for invoking the update.
+    pub fn command_args(self) -> (&'static str, &'static [&'static str]) {
+        match self {
+            UpdateAction::NpmGlobalLatest => ("npm", &["install", "-g", "@openai/codex@latest"]),
+            UpdateAction::BunGlobalLatest => ("bun", &["install", "-g", "@openai/codex@latest"]),
+            UpdateAction::BrewUpgrade => ("brew", &["upgrade", "codex"]),
+        }


Restore --cask in brew upgrade command

The new UpdateAction::BrewUpgrade now emits brew upgrade codex. Homebrew upgrades formulae by default and requires --cask to upgrade casks, so this command fails with “No available formula with the name ‘codex’” when the user confirms the update prompt or when the CLI auto‑runs the update after exit. The previous implementation correctly used brew upgrade --cask codex. Please reintroduce the flag so Brew installations actually update.

Useful? React with 👍 / 👎.

etraut-openai added the oai-pr label Nov 5, 2025

shijie-oai commented Nov 5, 2025

View reviewed changes

codex-rs/tui/src/updates.rs Show resolved Hide resolved

shijie-oai marked this pull request as ready for review November 5, 2025 14:34

shijie-oai requested a review from bolinfest November 5, 2025 14:34

bolinfest reviewed Nov 5, 2025

View reviewed changes

codex-rs/tui/src/updates.rs Show resolved Hide resolved

codex-rs/tui/src/updates.rs Outdated Show resolved Hide resolved

shijie-oai marked this pull request as draft November 5, 2025 17:09

shijie-oai added 2 commits November 7, 2025 12:09

fix: update brew auto update version check

e17d1ac

Support verion independently based on installation platform

2fa833e

shijie-oai force-pushed the shijie/update-brew-auto-update branch from e493207 to 2fa833e Compare November 7, 2025 20:09

shijie-oai added 2 commits November 7, 2025 14:36

Add comment

bddd982

fix build

409cbde

shijie-oai commented Nov 7, 2025

View reviewed changes

Update to cover initial brew version missing from existing json

a7ba34c

shijie-oai force-pushed the shijie/update-brew-auto-update branch from 4a198c4 to a7ba34c Compare November 8, 2025 00:02

shijie-oai commented Nov 8, 2025

View reviewed changes

shijie-oai requested a review from bolinfest November 8, 2025 00:05

shijie-oai marked this pull request as ready for review November 8, 2025 00:06

shijie-oai requested a review from etraut-openai November 8, 2025 00:07

chatgpt-codex-connector bot reviewed Nov 8, 2025

View reviewed changes

codex-rs/tui/src/updates.rs Outdated Show resolved Hide resolved

Move installer check up to latest version request level

c18b2aa

chatgpt-codex-connector bot reviewed Nov 8, 2025

View reviewed changes

Add cfg related complie path back

03ee5b7

shijie-oai force-pushed the shijie/update-brew-auto-update branch from c7bf6cc to 76c5897 Compare November 8, 2025 07:14

refactor for better conditional compilation

7ea7f34

shijie-oai force-pushed the shijie/update-brew-auto-update branch from 76c5897 to 7ea7f34 Compare November 8, 2025 07:25

bolinfest reviewed Nov 8, 2025

View reviewed changes

shijie-oai marked this pull request as draft November 8, 2025 23:06

Address review comments

99a6734

shijie-oai force-pushed the shijie/update-brew-auto-update branch from 0883d10 to 99a6734 Compare November 9, 2025 03:20

shijie-oai commented Nov 9, 2025

View reviewed changes

bolinfest reviewed Nov 10, 2025

View reviewed changes

bolinfest marked this pull request as ready for review November 10, 2025 00:24

bolinfest self-requested a review November 10, 2025 00:25

bolinfest approved these changes Nov 10, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Nov 10, 2025

View reviewed changes

shijie-oai added 2 commits November 9, 2025 17:10

Address review comments

1b4d1ab

Address review comments

1524199

shijie-oai merged commit 788badd into main Nov 10, 2025
25 checks passed

shijie-oai deleted the shijie/update-brew-auto-update branch November 10, 2025 17:05

github-actions bot locked and limited conversation to collaborators Nov 10, 2025


		use crate::version::CODEX_CLI_VERSION;

		pub fn get_upgrade_version(config: &Config) -> Option<String> {

fix: update brew auto update version check #6238

fix: update brew auto update version check #6238

Conversation

shijie-oai commented Nov 5, 2025

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shijie-oai Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

shijie-oai commented Nov 8, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

shijie-oai Nov 8, 2025 •

edited

Loading