Fix warning message phrasing #6446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a grammatical error in a warning message used throughout the codebase. The phrase "Start new a new conversation" has been corrected to "Start a new conversation" by removing the redundant word "new".
- Fixed grammatical error in warning message across 4 files
- Updated both source code and test files to maintain consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| codex-rs/tui/src/chatwidget/tests.rs | Updated test constant with corrected warning message |
| codex-rs/exec/tests/event_processor_with_json_output.rs | Updated test assertions with corrected warning message (2 occurrences) |
| codex-rs/core/tests/suite/compact.rs | Updated test constant with corrected warning message |
| codex-rs/core/src/codex/compact.rs | Updated source code warning message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
etraut-openai
approved these changes
Nov 10, 2025
Collaborator
|
Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for sentence phrasing in the warning message