Promote shared helpers for suite tests #6460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Nov 10, 2025
| call_id: &str, | ||
| arguments: &str, | ||
| tool_name: &str, | ||
| ) -> ToolSequenceMocks { |
Collaborator
Author
There was a problem hiding this comment.
It's not clear what each mock for tho
aibrahim-oai
force-pushed
the
codex/promote-local-helpers-to-core-tests
branch
2 times, most recently
from
9cffc44 to
46a4d81
Compare
pakrym-oai
approved these changes
Nov 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestCodex::submit_turn_with_policiesand extend the response helpers with reusable tool-call utilitiesanyhow::Resultso clippy no longer warns aboutexpectTesting
just fix -p codex-corecargo test -p codex-core --test all suite::grep_files::grep_files_tool_collects_matchescargo test -p codex-core suite::grep_files::grep_files_tool_collects_matches -- --ignored(filter requests ignored tests so nothing runs, but the build stays clean)Codex Task