Skip to content

Conversation

@nornagon-openai
Copy link
Collaborator

--disable shell_tool disables the built-in shell tool. This is useful for MCP-only operation.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nornagon-openai
Copy link
Collaborator Author

@codex fix

error[E0382]: borrow of moved value: `shell_handler`
   --> core/src/tools/spec.rs:999:39
    |
961 |     let shell_handler = Arc::new(ShellHandler);
    |         ------------- move occurs because `shell_handler` has type `std::sync::Arc<tools::handlers::shell::ShellHandler>`, which does not implement the `Copy` trait
...
995 |         builder.register_handler("local_shell", shell_handler);
    |                                                 ------------- value moved here
...
999 |     builder.register_handler("shell", shell_handler.clone());
    |                                       ^^^^^^^^^^^^^ value borrowed here after move
    |
note: consider changing this parameter type in method `register_handler` to borrow instead if owning the value isn't necessary
   --> core/src/tools/registry.rs:187:74
    |
187 |     pub fn register_handler(&mut self, name: impl Into<String>, handler: Arc<dyn ToolHandler>) {
    |            ---------------- in this method                               ^^^^^^^^^^^^^^^^^^^^ this parameter takes ownership of the value
help: clone the value to increment its reference count
    |
995 |         builder.register_handler("local_shell", shell_handler.clone());
    |                                                              ++++++++

@nornagon-openai nornagon-openai enabled auto-merge (squash) November 17, 2025 22:43
@nornagon-openai nornagon-openai merged commit ab2e749 into main Nov 17, 2025
25 checks passed
@nornagon-openai nornagon-openai deleted the nornagon/disable-shell branch November 17, 2025 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants