Add unified exec escalation handling and tests #6492
Merged
+208
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 2.10.0, and thiserror to 2.0.17 core/tests/suite/approvals.rs: workaround Linux sandbox arg0 test on ARM by using ReadOnly policy and cfg-gating test scenario
… use python3 test command
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Going to defer to @jif-oai for better context on the new tool framework
jif-oai
approved these changes
Nov 11, 2025
| "with_escalated_permissions".to_string(), | ||
| JsonSchema::Boolean { | ||
| description: Some( | ||
| "Whether to request escalated permissions. Set to true if command needs to be run without sandbox restrictions" |
Collaborator
There was a problem hiding this comment.
Did we eval the model with this parameter?
- Update error message to say "you cannot ask for escalated permissions" instead of "you should not ask" - Change justification in ExecCommandRequest from Option<&str> to Option<String> - Propagate String justification throughout unified_exec and session_manager
pakrym-oai
deleted the
codex/implement-exec_command-with-escalated-permissions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar implementation to the shell tool