feat: Add support for --add-dir to exec and TypeScript SDK #6565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
|
@danfhernandez, thanks for the contribution. Looks like there's a CI test failure that needs to be fixed. |
Contributor
Author
Fixed! |
danfhernandez
changed the title
Updated TypeScript SDK to use writeableRoots instead of additionalDirectories for better clarity. Also updated comment from --add-dir to --config sandbox_workspace_write.writable_roots to reflect the actual CLI usage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated the TypeScript SDK package.json to include the vendor folder in the published package files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
danfhernandez
changed the title
pakrym-oai
reviewed
Nov 13, 2025
pakrym-oai
reviewed
Nov 13, 2025
codex-rs/exec/tests/suite/add_dir.rs
Outdated
|
|
||
| /// Verify that the --add-dir flag is accepted and the command runs successfully. | ||
| /// This test confirms the CLI argument is properly wired up. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] |
Collaborator
There was a problem hiding this comment.
let's keep only on test that adds multiple
pakrym-oai
approved these changes
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for specifying additional directories in the TypeScript SDK through a new
additionalDirectoriesoption inThreadOptions.Changes
additionalDirectoriesparameter toThreadOptionsinterfaceCodexExecto accept and pass through additional directories via the--configflag forsandbox_workspace_write.writable_rootsTest plan
additionalDirectoriesis correctly passed as repeated flags