[app-server] small fixes for JSON schema export and one-of types #6614
+56
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenlin0
force-pushed
the
owen/fix_type_exports
branch
from
2007447 to
d37e5f9
Compare
owenlin0
changed the title
owenlin0
changed the title
owenlin0
changed the title
owenlin0
commented
Nov 13, 2025
codex-rs/tui/src/chatwidget/tests.rs
Outdated
| serde_json::Value::String(aggregated), | ||
| ); | ||
| } | ||
| } else if ty == "patch_apply_begin" { |
Contributor
Author
There was a problem hiding this comment.
needed since we now have a type descriminator on FileChange. note we don't actually persist EventMsg::PatchApplyBegin so adding the type descriminator is safe
celia-oai
approved these changes
Nov 14, 2025
Contributor
celia-oai
left a comment
celia-oai
left a comment
There was a problem hiding this comment.
thanks for fixing this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partner is consuming our generated JSON schema bundle for app-server and identified a few issues:
"$ref": "#/definitions/v2/SandboxPolicy"is missingThis PR:
SessionSourceandSubAgentSourcebecause they are serialized to disk (adding this would break backwards compat for resume), and they should not be necessary to consume for an integration with app-server.export.rsof various types like SandboxPolicy, which turned out to be unnecessary and incorrectOption<>which was auto-generated for request params that don't need a bodyFor context, we currently pull in wayyy more types than we need through the
EventMsggod object which we are not planning to expose in API v2 (this is how I suspectSessionSourceandSubAgentSourceare being pulled in). But until we have all the necessary v2 notifications in place that will allow us to removeEventMsg, we will keep exporting it for now.