Update defaults to gpt-5.1 #6652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/openai/codex into codex/update-models-to-gpt-5.1-and-gpt-5.1-codex
3 tasks
pakrym-oai
reviewed
Nov 17, 2025
|
|
||
| #[cfg(target_os = "windows")] | ||
| pub const OPENAI_DEFAULT_MODEL: &str = "gpt-5"; | ||
| pub const OPENAI_DEFAULT_MODEL: &str = "gpt-5.1"; |
pakrym-oai
reviewed
Nov 17, 2025
| } else if slug.starts_with("gpt-3.5") { | ||
| model_family!(slug, "gpt-3.5", needs_special_apply_patch_instructions: true) | ||
| } else if slug.starts_with("test-gpt-5-codex") { | ||
| } else if slug.starts_with("test-gpt-5") { |
Collaborator
Author
There was a problem hiding this comment.
to include test-gpt-5.1
Collaborator
Author
There was a problem hiding this comment.
oh yeah I wanted to support gpt-5.1-codex
just for tests
pakrym-oai
reviewed
Nov 17, 2025
| fn model_mapping_builds_tokenizer() -> Result<(), TokenizerError> { | ||
| // Choose a long-standing model alias that maps to cl100k_base. | ||
| let tok = Tokenizer::for_model("gpt-5")?; | ||
| let tok = Tokenizer::for_model("gpt-5.1")?; |
Collaborator
There was a problem hiding this comment.
does this actually work or do we get a fallback?
pakrym-oai
reviewed
Nov 17, 2025
pakrym-oai
reviewed
Nov 17, 2025
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Should we introduce const variables for default gpt and gpt-x-codex?
Collaborator
|
Is there a bad merge with this PR? Look like a lot of unrelated changes. |
…tps://github.com/openai/codex into codex/update-models-to-gpt-5.1-and-gpt-5.1-codex
pakrym-oai
approved these changes
Nov 17, 2025
aibrahim-oai
deleted the
codex/update-models-to-gpt-5.1-and-gpt-5.1-codex
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test -p codex-core config::tests::test_precedence_fixture_with_gpt5_profileCodex Task