Skip to content

Conversation

@aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Nov 14, 2025

This PR does the following:

  • Add compact prefix to the summary
  • Change the compaction prompt
  • Allow multiple compaction for long running tasks
  • Filter out summary messages on the following compaction

Considerations:

  • Filtering out the summary message isn't the most clean
  • Theoretically, we can end up in infinite compaction loop if the user messages > compaction limit . However, that's not possible in today's code because we have hard cap on user messages.
  • We need to address having multiple user messages because it confuses the model.

Testing:

  • Making sure that after compact we always end up with one user message (task) and one summary, even on multiple compaction.

@aibrahim-oai aibrahim-oai marked this pull request as ready for review November 14, 2025 22:47
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) November 15, 2025 06:25
@aibrahim-oai aibrahim-oai merged commit 0b28e72 into main Nov 15, 2025
25 checks passed
@aibrahim-oai aibrahim-oai deleted the fix-compact branch November 15, 2025 07:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants