fix: add more fields to ThreadStartResponse and ThreadResumeResponse #6847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following fields to
ThreadStartResponseandThreadResumeResponse:This is important because these fields are optional in
ThreadStartParamsandThreadResumeParams, so the caller needs to be able to determine what values were ultimately used to start/resume the conversation. (Though note that any of these could be changed later between turns in the conversation.)Though to get this information reliably, it must be read from the internal
SessionConfiguredEventthat is created in response to the start of a conversation. BecauseSessionConfiguredEvent(as defined incodex-rs/protocol/src/protocol.rs) did not have all of these fields, a number of them had to be added as part of this PR.Because
SessionConfiguredEventis referenced in many tests, test instances ofSessionConfiguredEventhad to be updated, as well, which is why this PR touches so many files.