windows sandbox: support multiple workspace roots #6854
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Overall, looks good.
I left one comment about error reporting, but I think that's fine to leave for a later time — especially given that the linux and MacOS sandboxes likewise don't do any error reporting here.
| allow.push(abs); | ||
|
|
||
| let mut add_path = |p: PathBuf| { | ||
| if seen.insert(p.to_string_lossy().to_string()) && p.exists() { |
There was a problem hiding this comment.
Looks like we don't provide any error reporting to users if the path is bad or doesn't exist. This will make it difficult for them to diagnose config issues.
There was a problem hiding this comment.
yeah good point. Seems like a good thing to add since they probably intend for these to be real directories. Would want to think about how "loudly" to report errors, ranging from an actual CLI failure (probably not) to a user-visible warning, to something in codex-tui.log
iceweasel-oai
deleted the
dev/iceweasel/support-multiple-workspace-roots
branch
The Windows sandbox did not previously support multiple workspace roots via config. Now it does