fix: typos in model picker #6859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Nov 19, 2025
pakrym-oai
reviewed
Nov 19, 2025
codex-rs/common/src/model_presets.rs
Outdated
| ], | ||
| is_default: false, | ||
| upgrade: Some(ModelUpgrade { | ||
| id: "gpt-5.1-codex", |
aibrahim-oai
force-pushed
the
fix-typos
branch
from
41d9205 to
84ae009
Compare
pakrym-oai
reviewed
Nov 19, 2025
| ], | ||
| ), | ||
| ( | ||
| "gpt-5.1", |
Collaborator
Author
There was a problem hiding this comment.
It's a bad merge that went in I guess the one above it it gpt5.1 as well
pakrym-oai
reviewed
Nov 19, 2025
| .iter() | ||
| .filter(|preset| preset.upgrade.is_none()) | ||
| .filter(|preset| match auth_mode { | ||
| Some(AuthMode::ApiKey) => preset.show_in_picker && preset.id != "arcticfox", |
Collaborator
There was a problem hiding this comment.
not blocking: we should have a preset property for this
pakrym-oai
reviewed
Nov 19, 2025
| codex_home, | ||
| None, | ||
| &[ConfigEdit::SetNoticeHideModelMigrationPrompt( | ||
| "hide_arcticfox_migration_prompt".to_string(), |
Collaborator
There was a problem hiding this comment.
this test already exists
pakrym-oai
reviewed
Nov 19, 2025
| 1. Low Fast responses with lighter reasoning | ||
| 2. Medium (default) Balances speed and reasoning depth for everyday tasks | ||
| › 3. High (current) Maximizes reasoning depth for complex problems | ||
| ⚠ High reasoning effort can quickly consume Plus plan |
Collaborator
There was a problem hiding this comment.
Do we need the warning for xhigh?
pakrym-oai
reviewed
Nov 19, 2025
codex-rs/tui/src/app.rs
Outdated
| app_event_tx: &AppEventSender, | ||
| auth_mode: Option<AuthMode>, | ||
| ) -> Option<AppExitInfo> { | ||
| if matches!(auth_mode, Some(AuthMode::ApiKey)) { |
Collaborator
There was a problem hiding this comment.
API has all 5.1 models now
pakrym-oai
reviewed
Nov 19, 2025
| }); | ||
| } | ||
|
|
||
| fn reasoning_effort_label(effort: ReasoningEffortConfig) -> &'static str { |
Collaborator
There was a problem hiding this comment.
non blocking: toss this onto ReasoningEffortConfig ?
pakrym-oai
approved these changes
Nov 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.
Include a link to a bug report or enhancement request.