-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[core] add optional status_code to error events #6865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb4fe6a to
482a1fb
Compare
09d0b8b to
6ad8a5d
Compare
6ad8a5d to
04b49ca
Compare
💡 Codex Reviewcodex/codex-rs/protocol/src/protocol.rs Lines 1355 to 1361 in 6ad8a5d
With this commit ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
owenlin0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 👍
04b49ca to
17d478e
Compare
436da71 to
6425f44
Compare
6425f44 to
9be42ef
Compare
We want to better uncover error status code for clients. Add an optional status_code to error events (for core error, stream error events) so app server could uncover the status code from the client side later.
in event log: