chore: drop model_max_output_tokens #7100
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| config.model_reasoning_effort, | ||
| config.model_reasoning_summary, | ||
| config.model_context_window, | ||
| config.model_max_output_tokens, | ||
| config.model_auto_compact_token_limit, | ||
| config.approval_policy, |
There was a problem hiding this comment.
This call now omits the max_output_tokens argument that OtelEventManager::conversation_starts still requires (codex-rs/otel/src/otel_event_manager.rs, lines 85-96). As written the crate will no longer compile because the function expects ten parameters and we only supply nine. Please continue passing an argument here (e.g. None) or adjust the OTEL helper’s signature in the same change so the build succeeds.
Useful? React with 👍 / 👎.
No description provided.