[app-server] fix: emit item/fileChange/outputDelta for file change items #7399
+70
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenlin0
force-pushed
the
owen/fix_apply_patch_delta
branch
from
b3b69fe to
c84a89d
Compare
jif-oai
reviewed
Dec 1, 2025
| let notification = CommandExecutionOutputDeltaNotification { | ||
| item_id: exec_command_output_delta_event.call_id.clone(), | ||
| delta: String::from_utf8_lossy(&exec_command_output_delta_event.chunk).to_string(), | ||
| let item_id = exec_command_output_delta_event.call_id.clone(); |
Collaborator
There was a problem hiding this comment.
Can you add a comment to explain the condition which is built here. I'm not sure to fully understand it
owenlin0
force-pushed
the
owen/fix_apply_patch_delta
branch
from
c1be76e to
2d0f224
Compare
owenlin0
force-pushed
the
owen/fix_apply_patch_delta
branch
from
2d0f224 to
482980e
Compare
jif-oai
approved these changes
Dec 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit
item/fileChange/outputDeltainstead ofitem/execCommand/outputDeltafor FileChange items.The underlying
EventMsg::ExecCommandOutputDeltais emitted for apply_patch, shell, and unified exec, and since we represent apply_patch calls asFileChangeitems, we were seeing these events:With this fix we'll have these events: