-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat: experimental support for skills.md #7412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Tibo, I’m excited for this feature to be merged. Are you able to clarify something for me? Does the skill run in its own context or does it pollute the global context? For example say I have a GTM expert skill that navigates a GTM container json (sometimes 100k tokens). When the agent uses the skill to answer a question, it might want to read some or all of the json. Would this then bleed into the main context? |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| names | ||
| } | ||
|
|
||
| fn merge_project_docs_with_skills( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get rid of this as well?
| assert_message_ends_with(&request_body["input"][1], "</environment_context>"); | ||
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a separate file skills.rs and follow the pattern that uses test_codex()
This change prototypes support for Skills with the CLI. This is an experimental feature for internal testing.