Fix: track only untracked paths in ghost snapshots #7470
Merged
+121
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lionelchg <[email protected]>
jif-oai
approved these changes
Dec 2, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Can you add a few more tests where you create/delete ignored files and make sure they get ignored?
Signed-off-by: lionelchg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ghost snapshot ignores
This PR should close #7067, #7395, #7405.
Prior to this change the ghost snapshot task ran
git status --ignored=matchingso the report picked up literally every ignored file. When a directory only contained entries matched by patterns such asdozens/*.txt,/test123/generated/*.html, or/wp-includes/*, Git still enumerated them and the large-untracked-dir detection treated the parent directory as “large,” even though everything inside was intentionally ignored.By removing
--ignored=matchingwe only capture true untracked paths now, so those patterns stay out of the snapshot report and no longer trigger the “large untracked directories” warning.