seatbelt: allow openpty() #7507
Merged
+57
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
approved these changes
Dec 3, 2025
| assert!(status.success(), "python exited with {status:?}"); | ||
| } | ||
|
|
||
| #[tokio::test] |
Collaborator
There was a problem hiding this comment.
Does this test pass on both Mac and Linux? If so, can we define it in codex-rs/exec/tests/suite/sandbox.rs instead to verify sandbox parity across platforms?
Collaborator
Author
There was a problem hiding this comment.
@codex can you move this test to the cross-platform suite
Contributor
There was a problem hiding this comment.
Summary
- Added a cross-platform
openptysandbox regression test to the shared exec suite so both macOS and Linux sandbox implementations are exercised and the test skips when required binaries are unavailable. exec/tests/suite/sandbox.rsL112-L150 - Removed the macOS-only copy of the
openptycheck from the seatbelt suite now that coverage lives in the shared sandbox tests. core/tests/suite/seatbelt.rsL123-L205 - Added the
whichdev-dependency forcodex-exec(and recorded it in the lockfile) to support the relocated test. exec/Cargo.tomlL52-L63 Cargo.lockL1210-L1249
Testing
- ❌
cargo test -p codex-exec(fails in this environment with landlock restrictions and loopback 403 errors) - ❌
cargo test -p codex-core(fails in this environment because expected user-agent headers and sandboxed process control are unavailable)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
openpty(3)to run in the default sandbox. Also permit readingkern.argmax, which is the maximum number of arguments to exec().