Refactor execpolicy fallback evaluation #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
4 times, most recently
from
00d6382 to
505b845
Compare
zhao-oai
force-pushed
the
pr7033
branch
2 times, most recently
from
65b6984 to
0d121de
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
505b845 to
09a1786
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
09a1786 to
d49a447
Compare
zhao-oai
force-pushed
the
pr7033
branch
3 times, most recently
from
86b1d98 to
31c5e11
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
d49a447 to
01a8814
Compare
bolinfest
approved these changes
Dec 4, 2025
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
2 times, most recently
from
1cc4c2d to
27804c3
Compare
Add explicit prefix-approval decision and wire it through execpolicy/UI snapshots update doc mutating in memory policy instead of reloading using RW locks clippy refactor: adding allow_prefix into ApprovedAllowPrefix fmt do not send allow_prefix if execpolicy is disabled moving args around cleanup exec_policy getters undo diff fixing rw lock bug causing tui to hang updating phrasing integration test . fix compile fix flaky test fix compile error running test with single thread fixup allow_prefix_if_applicable fix formatting fix approvals test only cloning when needed docs add docstring fix rebase bug fixing rebase issues Revert "fixing rebase issues" This reverts commit 79ce7e1. fix rebase errors
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
c12dd09 to
4488061
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the
execpolicycrateTo illustrate why we need this refactor, consider an agent attempting to run
apple | rm -rf ./. Supposeappleis allowed byexecpolicy. Before this PR,execpolicywould considerappleandpearand only render one rule match:Allow. We would skip any heuristics checks onrm -rf ./and immediately approveapple | rm -rf ./to run.To fix this, we now thread a
fallbackevaluation function intoexecpolicythat runs when noexecpolicyrules match a given command. In our example, we would runfallbackonrm -rf ./and preventapple | rm -rf ./from being run without approval.