Migrate codex max #7566
Migrate codex max #7566
Conversation
aibrahim-oai
commented
Dec 4, 2025
aibrahim-oai
commented
- make codex max the default
- fix: we were doing some async work in sync function which caused tui to panic
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub(crate) fn builtin_model_presets(_auth_mode: Option<AuthMode>) -> Vec<ModelPreset> { | ||
| PRESETS | ||
| .iter() | ||
| .filter(|preset| match auth_mode { | ||
| Some(AuthMode::ApiKey) => preset.show_in_picker && preset.id != "gpt-5.1-codex-max", | ||
| _ => preset.show_in_picker, | ||
| }) | ||
| .filter(|preset| preset.show_in_picker) | ||
| .cloned() |
There was a problem hiding this comment.
builtin_model_presets now ignores the provided auth mode and returns every preset marked show_in_picker, so calls with AuthMode::ApiKey still include gpt-5.1-codex-max. The unit test gpt_5_1_codex_max_hidden_for_api_key_auth in this file still asserts that codex-max is hidden for API key users, so running the core crate tests will fail on this commit until the picker logic or the test is updated to match the intended behavior.
Useful? React with 👍 / 👎.
