Skip to content

Conversation

@voctory
Copy link
Contributor

@voctory voctory commented Dec 6, 2025

Update install and contributing guides to use the root justfile helpers (just fmt, just fix -p <crate>, and targeted tests) instead of the older cargo fmt/clippy/test instructions that have been in place since 459363e. This matches the justfile relocation to the repo root in 952d6c9 and the current lint/test workflow for CI (see .github/workflows/rust-ci.yml).

Update install and contributing guides to use the root justfile helpers (`just fmt`, `just fix -p <crate>`, and targeted tests) instead of the older cargo fmt/clippy/test instructions that have been in place since 459363e. This matches the justfile relocation to the repo root in 952d6c9 and the current lint/test workflow.
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@voctory
Copy link
Contributor Author

voctory commented Dec 6, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 6, 2025
@etraut-openai
Copy link
Collaborator

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai added the needs-response Additional information is requested label Dec 7, 2025
@etraut-openai
Copy link
Collaborator

@voctory, thanks for the contribution. Please take a look at the codex code review feedback above.

Address review feedback by adding install steps for just (used by the root justfile) and cargo-nextest (used by just test) in docs/install.md, with a cargo test --all-features fallback for environments without nextest.
@voctory
Copy link
Contributor Author

voctory commented Dec 7, 2025

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@voctory
Copy link
Contributor Author

voctory commented Dec 7, 2025

@etraut-openai Thanks for taking a look - addressed the feedback and passes the codex review.

@etraut-openai etraut-openai removed the needs-response Additional information is requested label Dec 7, 2025
@etraut-openai etraut-openai merged commit b2cb05d into openai:main Dec 7, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2025
@etraut-openai
Copy link
Collaborator

Thanks for the contribution! Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants