Add formatting client version to the x.x.x style.
#7711
Merged
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Dec 8, 2025
pakrym-oai
requested changes
Dec 8, 2025
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Can we simplify and always use built-in vars ?
pakrym-oai
reviewed
Dec 8, 2025
|
|
||
| fn format_client_version_from_parts(major: &str, minor: &str, patch: &str) -> String { | ||
| const DEV_VERSION: &str = "0.0.0"; | ||
| const FALLBACK_VERSION: &str = "99.99.99"; |
Collaborator
There was a problem hiding this comment.
curious how did you think about making this fallback on the client vs server?
Collaborator
Author
There was a problem hiding this comment.
Followed your approach. Clients better have control instead of aggressively overriding it when possible
pakrym-oai
approved these changes
Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid regression with special builds like alphas