updating app server types to support execpoilcy amendment #7747
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
zhao-oai
force-pushed
the
dev/zhao/update-app-server-types
branch
from
4578541 to
c744af7
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
zhao-oai
force-pushed
the
dev/zhao/update-app-server-types
branch
from
c744af7 to
9c16c51
Compare
| /// Optional approval settings for when the decision is `accept`. | ||
| /// Ignored if the decision is `decline` or `cancel`. | ||
| #[serde(default)] | ||
| pub accept_settings: Option<CommandExecutionRequestAcceptSettings>, |
There was a problem hiding this comment.
why is this getting deleted? is this backward compatible / do we lose information?
also includes minor refactor merging
ApprovalDecisionwithCommandExecutionRequestAcceptSettings