Remove conversation_id and bring back request ID logging #7830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-back-request-id-logging # Conflicts: # codex-rs/core/Cargo.toml
pakrym-oai
changed the title
jif-oai
approved these changes
Dec 10, 2025
| } | ||
|
|
||
| fn extract_request_ids(response: &Response) -> HashMap<String, String> { | ||
| ["cf-ray", "x-request-id", "x-oai-request-id"] |
Collaborator
There was a problem hiding this comment.
This is some kind of business logic... I would not have this here. What if we use this client to reach another API?
Collaborator
Author
There was a problem hiding this comment.
It's not required that the header exists and most calls we make are to OpenAI APIs. I'd rather get every request ID possible.
codex-rs/core/src/default_client.rs
Outdated
| use std::sync::Mutex; | ||
| use std::sync::OnceLock; | ||
|
|
||
| pub use codex_client::CodexHttpClient; |
Collaborator
There was a problem hiding this comment.
Let's maybe drop this and have proper import when we need them instead
pakrym-oai
deleted the
pakrym/remove-conversation-id-and-keep-bring-back-request-id-logging
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.