[app-server] make app server not throw error when login id is not found #7831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
2cdb895 to
993bdc3
Compare
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
993bdc3 to
d87ad5b
Compare
celia-oai
changed the title
bolinfest
reviewed
Dec 10, 2025
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
d25dc0f to
734d5b4
Compare
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
734d5b4 to
b723907
Compare
bolinfest
reviewed
Dec 10, 2025
| timeout(DEFAULT_READ_TIMEOUT, mcp.initialize()).await??; | ||
|
|
||
| let request_id = mcp | ||
| .send_cancel_login_account_request(CancelLoginAccountParams { |
Collaborator
There was a problem hiding this comment.
Just so I'm clear: we're sending a cancel request, but we never send send_login_account_chatgpt_request()? Is that a realistic flow or is this just the best we can do for this test?
Contributor
Author
There was a problem hiding this comment.
removing this test as it causes more confusion than needed haha. it's not a realistic workflow but we don't error out if there's a race condition for login finishes before canceling
Contributor
Author
There was a problem hiding this comment.
also deleting login_and_cancel_chatgpt v1 test which is flaky. should be safe since all clients have migrated off of this.
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
f54f840 to
d75ab1b
Compare
celia-oai
force-pushed
the
dev/cc/fix-cancel
branch
from
d75ab1b to
6ba0501
Compare
bolinfest
approved these changes
Dec 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous design of cancellation endpoint is not idempotent, which caused a bunch of flaky tests. Make app server just returned a not_found status instead of throwing an error if the login id is not found. Keep V1 endpoint behavior the same.