Skip to content

Conversation

@etraut-openai
Copy link
Collaborator

This addresses bug #7857 which was introduced recently as part of PR #7704.

This addresses bug #7857 which was introduced recently as part of PR #7704.
@etraut-openai
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@448523760
Copy link
Contributor

448523760 commented Dec 11, 2025

Hi @etraut-opena Fuzzy match can cause a #7704 regression. To support both fuzzy matching and "/" history rollback, add a content-source flag to sync_command_popup (user input vs. history rollback). This is a significant change. And I did not make that change previous on #7704. Instead, i just made smallest change which by verifying the prefix between content and the pre-built commands

@etraut-openai
Copy link
Collaborator Author

@448523760, I'd like to get a fix for the fuzzy match regression in place. I think it impacts many more users than the other issue, which is pretty niche. You're welcome to address the other issue in a follow-up PR if you'd like.

@etraut-openai etraut-openai merged commit 0572500 into main Dec 11, 2025
44 of 47 checks passed
@etraut-openai etraut-openai deleted the etraut/fuzzy branch December 11, 2025 04:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants